Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6447] Add GitHub Action to add Labels on Pull Requests #7032

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Jan 3, 2020

Add GitHub Action to add Labels on Pull Requests. I have tested this on my local fork


Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-6447

  • Description above provides context of the change
  • Commit message starts with [AIRFLOW-NNNN], where AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

(*) For document-only changes, no JIRA issue is needed. Commit message starts [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@kaxil kaxil requested review from potiuk and dimberman January 3, 2020 23:01
Copy link
Contributor

@dimberman dimberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimberman dimberman merged commit e9ebe7a into apache:master Jan 3, 2020
---

provider:GCP:
- airflow/**/gcp/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCP also have code in airflow/gcp directory. Will this work?

Copy link
Member Author

@kaxil kaxil Jan 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it would not, missed it. We will have to add that. Also, we hit a roadblock, check this: https://lists.apache.org/thread.html/03a94f681c96195f0359ed795a044591e864c8a9367cfa883fab92ba%40%3Cdev.airflow.apache.org%3E

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on INFRA team now

@kaxil kaxil deleted the ga-labeller branch January 4, 2020 00:51
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants